-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support contextual logging #549
Support contextual logging #549
Conversation
Skipping CI for Draft Pull Request. |
152536a
to
c735744
Compare
c735744
to
7110cda
Compare
/wg structured-logging |
Co-authored-by: Jan Šafránek <[email protected]>
@jsafrane Thank you for your review. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bells17, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
I've updated the klog functions used within csi-lib-utils to contextual logging functions, following the guidelines below:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
make test
ormake logcheck
)Does this PR introduce a user-facing change?: