Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade csi-lib-utils to version 0.8.1 #254

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Upgrade csi-lib-utils to version 0.8.1 #254

merged 2 commits into from
Oct 6, 2020

Conversation

Jiawei0227
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Upgrade csi-lib-utils to version 0.8.1

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add `process_start_time_seconds` metric.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Jiawei0227. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 2, 2020
@Jiawei0227
Copy link
Contributor Author

/assign @msau42

@jsafrane
Copy link
Contributor

jsafrane commented Oct 6, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2020
@msau42
Copy link
Collaborator

msau42 commented Oct 6, 2020

/retest

@msau42
Copy link
Collaborator

msau42 commented Oct 6, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jiawei0227, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@msau42
Copy link
Collaborator

msau42 commented Oct 6, 2020

/retest

@Jiawei0227
Copy link
Contributor Author

I will cherrypick the change to previous branch. No need for 3.0
/close

@Jiawei0227 Jiawei0227 closed this Oct 6, 2020
@msau42
Copy link
Collaborator

msau42 commented Oct 6, 2020

Why do we not need 3.0? If we cherry-pick to older branches, we should make sure all later releases also have the change

@Jiawei0227 Jiawei0227 reopened this Oct 6, 2020
@Jiawei0227
Copy link
Contributor Author

Okay, sure. I will reopen this.

@k8s-ci-robot k8s-ci-robot merged commit 63601bf into kubernetes-csi:release-3.0 Oct 6, 2020
dfajmon pushed a commit to dfajmon/csi-external-attacher that referenced this pull request Aug 14, 2024
@solumath
Squashed 'release-tools/' changes from adb3af9d..988496a1
f72f921 
988496a1 Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path
028f8c69 chore: bump to Go 1.22.5
69bd71e8 chore: add CSI_PROW_SIDECAR_E2E_PATH
f40f0ccd Merge pull request kubernetes-csi#256 from solumath/master
cfa92106 Instruction update
379a1bb9 Merge pull request kubernetes-csi#255 from humblec/sidecar-md
a5667bbb fix typo in sidecar release process
49676850 Merge pull request kubernetes-csi#254 from bells17/add-github-actions
d9bd160c Update skip list in codespell GitHub Action
f5aebfc9 Add GitHub Actions workflows

git-subtree-dir: release-tools
git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
dfajmon added a commit to dfajmon/csi-external-attacher that referenced this pull request Aug 14, 2024
@dfajmon
Squashed 'release-tools/' changes from adb3af9d..988496a1
6d406c8 
988496a1 Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path
028f8c69 chore: bump to Go 1.22.5
69bd71e8 chore: add CSI_PROW_SIDECAR_E2E_PATH
f40f0ccd Merge pull request kubernetes-csi#256 from solumath/master
cfa92106 Instruction update
379a1bb9 Merge pull request kubernetes-csi#255 from humblec/sidecar-md
a5667bbb fix typo in sidecar release process
49676850 Merge pull request kubernetes-csi#254 from bells17/add-github-actions
d9bd160c Update skip list in codespell GitHub Action
f5aebfc9 Add GitHub Actions workflows

git-subtree-dir: release-tools
git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@lpabon lpabon Awaiting requested review from lpabon

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jiawei0227 @k8s-ci-robot @jsafrane @msau42