Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 1.0 RC1 release #157

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Changelog for 1.0 RC1 release #157

merged 1 commit into from
Jun 21, 2021

Conversation

ddebroy
Copy link
Contributor

@ddebroy ddebroy commented Jun 21, 2021

Note that Disk, Volume, FS and SMB API groups will be moving up to v1 as part of the v1 RC 1 -> v1 transition.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design

/kind documentation

/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Changelog for 1.0 RC1 release

Does this PR introduce a user-facing change?:
No

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Jun 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddebroy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2021
@jingxu97
Copy link
Contributor

/assign @mauriciopoppe
lgtm, @mauriciopoppe could you give a final review?

### API
- v1beta2 SMB API group with error field removed from all API response msgs ([#146](https://github.com/kubernetes-csi/csi-proxy/pull/146), [@mauriciopoppe](https://github.com/mauriciopoppe))
- v1beta2 FileSystem API group with renamed APIs LinkPath -> CreateSymlink and IsMountPoint -> IsSymlink and error field removed from all API response msgs ([#143](https://github.com/kubernetes-csi/csi-proxy/pull/143), [@mauriciopoppe](https://github.com/mauriciopoppe))
- v1beta3 Disk API group with renamed APIs DiskStats -> GetDiskStats, SetAttachState -> SetDiskState and SetAttachState -> GetDiskState ([#140](https://github.com/kubernetes-csi/csi-proxy/pull/140), [@mauriciopoppe](https://github.com/mauriciopoppe))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a few changes in the message fields too, the one that's important was changing disk_id (string) to disk_number (uint32) in Volume and Disk, these change are summarized in the github issues attached to each PR.

I think we could add something like:

The complete list of changes is summarized in #[issue number]

@mauriciopoppe
Copy link
Member

@jingxu97 suggested adding more changes in a document that has more details on how to upgrade, I think that's a good approach too

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 327ebfb into kubernetes-csi:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants