-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog for 1.0 RC1 release #157
Conversation
Signed-off-by: Deep Debroy <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ddebroy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @mauriciopoppe |
### API | ||
- v1beta2 SMB API group with error field removed from all API response msgs ([#146](https://github.com/kubernetes-csi/csi-proxy/pull/146), [@mauriciopoppe](https://github.com/mauriciopoppe)) | ||
- v1beta2 FileSystem API group with renamed APIs LinkPath -> CreateSymlink and IsMountPoint -> IsSymlink and error field removed from all API response msgs ([#143](https://github.com/kubernetes-csi/csi-proxy/pull/143), [@mauriciopoppe](https://github.com/mauriciopoppe)) | ||
- v1beta3 Disk API group with renamed APIs DiskStats -> GetDiskStats, SetAttachState -> SetDiskState and SetAttachState -> GetDiskState ([#140](https://github.com/kubernetes-csi/csi-proxy/pull/140), [@mauriciopoppe](https://github.com/mauriciopoppe)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were a few changes in the message fields too, the one that's important was changing disk_id (string) to disk_number (uint32) in Volume and Disk, these change are summarized in the github issues attached to each PR.
I think we could add something like:
The complete list of changes is summarized in #[issue number]
@jingxu97 suggested adding more changes in a document that has more details on how to upgrade, I think that's a good approach too /lgtm |
Note that Disk, Volume, FS and SMB API groups will be moving up to v1 as part of the v1 RC 1 -> v1 transition.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Changelog for 1.0 RC1 release
Does this PR introduce a user-facing change?:
No