upload csiproxy binary to gcs with version information #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
msau42
reviewed
Jun 4, 2021
Makefile
Outdated
| VERSION=$(shell git describe) | ||
| REV=$(shell git describe --long --tags --match='v*' --dirty 2>/dev/null || git rev-list -n1 HEAD) | ||
|
|
||
| $(info PULL_BASE_REF is $(PULL_BASE_REF)) |
There was a problem hiding this comment.
it doesn't look like're using these values in the bucket path. Is that right?
There was a problem hiding this comment.
actually I am still testing and verifying this part, so put WIP in this PR. sorry for the confusion.
jingxu97
changed the title
jingxu97
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
jingxu97
force-pushed
the
may/build
branch
5 times, most recently
from
1f4d49a to
ece6aad
Compare
k8s-ci-robot
added
size/XS
jingxu97
changed the title
k8s-ci-robot
added
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
add logic to upload binary to gcs with version information
k8s-ci-robot
removed
lgtm
|
@ddebroy @mauriciopoppe could you lgtm again? Thanks! |
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
removed
the
do-not-merge/release-note-label-needed
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add logic to upload binary to gcs with version information
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: