Fix IsVolumeFormatted issue on checking volume type "Unknown"

[jingxu97]

This PR fixes issue in IsVolumeFormatted on checking volume type
"Unknown"

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[wongma7]

thx so much for quick fix, I just tested this patch and can confirm it works for me. I added a little log statement to verify that my "raw" volumes are showing up with Unknown FS for me and matching the new condition:

W0415 19:13:08.177499 10684 api.go:82] STRING "Unknown"

diff --git a/internal/os/volume/api.go b/internal/os/volume/api.go
index 74f0401..afdcf3b 100644
--- a/internal/os/volume/api.go
+++ b/internal/os/volume/api.go
@@ -7,6 +7,8 @@ import (
        "regexp"
        "strconv"
        "strings"
+
+       "k8s.io/klog/v2"
 )
 
 const formatFilesystem = "ntfs"
@@ -76,7 +78,9 @@ func (VolAPIImplementor) IsVolumeFormatted(volumeID string) (bool, error) {
        if err != nil {
                return false, fmt.Errorf("error checking if volume is formatted. cmd: %s, output: %s, error: %v", cmd, string(out), err)
        }
-       if len(strings.TrimSpace(string(out))) == 0 {
+       stringOut := strings.TrimSpace(string(out))
+       klog.Warningf("STRING %q", stringOut)
+       if len(stringOut) == 0 || strings.EqualFold(stringOut, "Unknown") {
                return false, nil
        }
        return true, nil

[wongma7]

/lgtm

[k8s-ci-robot]

@wongma7: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jingxu97]

/lgtm

[k8s-ci-robot]

@jingxu97: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jingxu97]

/assign @ddebroy

[ddebroy]

/lgtm
/approve

[jingxu97]

/lgtm

[k8s-ci-robot]

@jingxu97: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, ddebroy, jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx,ddebroy,jingxu97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment