leaderelection add context

[aimuz]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add context

Does this PR introduce a user-facing change?:

leaderelection add WithContext func

[k8s-ci-robot]

Hi @aimuz. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

[pohly]

/check-cla

[aimuz]

/assign @msau42

[pohly]

Nit: I don't like that it modifies l here. I can't quite nail it, but it feels wrong.

Also, why "context.TODO()"? That implies that the code needs further work. What is that missing work? If this is final, use `context.Background()'. If not, explain what needs to be done.

I'd prefer:

ctx := l.ctx
if ctx == nil {
    ctx = context.Background()
}
leaderelection.RunOrDie(ctx, leaderConfig)

[aimuz]

use "context.TODO()" because it was like this before, but now it seems to be true "context.Background()" better.

I have recommitted the code

[pohly]

/lgtm

[aimuz]

@saad-ali

[pohly]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment