Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kube and dependencies to v1.18.0. #39

Merged
merged 2 commits into from
Apr 14, 2020
Merged

update kube and dependencies to v1.18.0. #39

merged 2 commits into from
Apr 14, 2020

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Apr 8, 2020 •
edited
Loading

Signed-off-by: Humble Chirammal [email protected]

Action required: client-go gets updated to Kubernetes 1.18.0 which changes the API of several functions (context added, create/delete/update options).

@humblec
Update vendor dependencies
b4c26bd 
Signed-off-by: Humble Chirammal <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 8, 2020
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali April 8, 2020 06:40
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 8, 2020
@humblec
Copy link
Contributor Author

humblec commented Apr 8, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 8, 2020
@humblec
Copy link
Contributor Author

humblec commented Apr 8, 2020

@pohly Please review.

pohly
pohly approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I'm just not sure yet whether the dependency update and the API change in client-go imply that we need to do a major version bump. Let me check that. At the very least it needs to be mentioned in the change note.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2020
@humblec
Copy link
Contributor Author

humblec commented Apr 11, 2020

/assign @msau42
/assign @pohly

@msau42
Copy link
Collaborator

msau42 commented Apr 13, 2020

@humblec can you add a release note?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 14, 2020
@humblec
Copy link
Contributor Author

humblec commented Apr 14, 2020

@humblec can you add a release note?

@msau42 done.. ptal.

@pohly
Copy link
Contributor

pohly commented Apr 14, 2020

done.. ptal.

This is very verbose. Something shorter like "Action required: client-go gets updated to Kubernetes 1.18.0 which changes the API of several functions (context added, create/delete/update options)" should be enough.

According to the discussion in https://kubernetes.slack.com/archives/C5P3FE08M/p1586337032010800, this is a major API change for libraries because the updated csi-lib-utils isn't guaranteed to be usable in downstream components unless those components adapt to the modified client-go interface.

We can merge this PR and bump the /v suffix of the module as part of preparing the next release.

@humblec humblec changed the title update kube and depenencies to v.1.18.0 version.. update kube and dependencies to v1.18.0. Apr 14, 2020
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 14, 2020
@humblec
Copy link
Contributor Author

humblec commented Apr 14, 2020

done.. ptal.

This is very verbose. Something shorter like "Action required: client-go gets updated to Kubernetes 1.18.0 which changes the API of several functions (context added, create/delete/update options)" should be enough.

According to the discussion in https://kubernetes.slack.com/archives/C5P3FE08M/p1586337032010800, this is a major API change for libraries because the updated csi-lib-utils isn't guaranteed to be usable in downstream components unless those components adapt to the modified client-go interface.

We can merge this PR and bump the /v suffix of the module as part of preparing the next release.

@pohly completely accepted the release note as you suggested :). PTAL

@humblec
Copy link
Contributor Author

humblec commented Apr 14, 2020

@msau42 ptal.

msau42
msau42 reviewed Apr 14, 2020
View reviewed changes
@humblec
vendor dir update.
0402e0a 
Signed-off-by: Humble Chirammal <[email protected]>
@msau42
Copy link
Collaborator

msau42 commented Apr 14, 2020

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 17e94e4 into kubernetes-csi:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@pohly pohly pohly approved these changes

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@pohly pohly

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@humblec @msau42 @pohly @k8s-ci-robot