Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency go modules for k8s v1.28.0-rc.0 #141

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Update dependency go modules for k8s v1.28.0-rc.0 #141

merged 3 commits into from
Aug 9, 2023

Conversation

Sneha-at
Copy link
Contributor

@Sneha-at Sneha-at commented Jul 31, 2023 •
edited by sunnylovestiramisu
Loading

Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p 1.28.0-rc.0

NONE

Sneha-at added 2 commits July 31, 2023 18:33
@Sneha-at
Squashed 'release-tools/' changes from 4133d1d..1df23db
9c786c7 
1df23db Merge pull request #230 from msau42/prow
1f92b7e Add ginkgo timeout to e2e tests to help catch any stuck tests
c10b678 Merge pull request #227 from coulof/check-sidecar-supported-versions
b055535 Header
bd0a10b typo
c39d73c Add comments
f6491af Script to verify EOL sidecar version

git-subtree-dir: release-tools
git-subtree-split: 1df23dba61da5d4e52ae79e6e1571f9d1d94311d
@Sneha-at
Merge commit '9c786c770969516d5c0d95c2a0c42eaee46c9451' into module-u…
fdfdc92 
…pdate-master
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 31, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Sneha-at!

It looks like this is your first PR to kubernetes-csi/csi-lib-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-lib-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Sneha-at. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 31, 2023
@sunnylovestiramisu
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2023
@sunnylovestiramisu
Copy link
Contributor

/release-note none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 31, 2023
@Sneha-at
Copy link
Contributor Author

Sneha-at commented Aug 2, 2023

/assign xing-yang

sunnylovestiramisu
sunnylovestiramisu reviewed Aug 3, 2023
View reviewed changes
@Sneha-at Sneha-at force-pushed the module-update-master branch from 1af768e to 0ed3765 Compare August 9, 2023 17:32
@sunnylovestiramisu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Aug 9, 2023
Merged
@xing-yang
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sneha-at, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit b6ca620 into kubernetes-csi:master Aug 9, 2023
@Sneha-at Sneha-at mentioned this pull request Aug 17, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@sunnylovestiramisu sunnylovestiramisu sunnylovestiramisu left review comments

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@RaunakShah RaunakShah Awaiting requested review from RaunakShah

Assignees

@xing-yang xing-yang

@sunnylovestiramisu sunnylovestiramisu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sneha-at @k8s-ci-robot @sunnylovestiramisu @xing-yang