Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix storageclass uncleaned #779

Merged
merged 1 commit into from
May 11, 2024
Merged

test: fix storageclass uncleaned #779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/e2e/testsuites/dynamically_provisioned_reclaim_policy_tester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,14 @@ package testsuites

import (
"context"

"github.com/kubernetes-csi/csi-driver-smb/pkg/smb"
"github.com/kubernetes-csi/csi-driver-smb/test/e2e/driver"

v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
clientset "k8s.io/client-go/kubernetes"
"k8s.io/kubernetes/test/e2e/framework"
)

// DynamicallyProvisionedReclaimPolicyTest will provision required PV(s) and PVC(s)
Expand All @@ -37,6 +40,11 @@ type DynamicallyProvisionedReclaimPolicyTest struct {
func (t *DynamicallyProvisionedReclaimPolicyTest) Run(ctx context.Context, client clientset.Interface, namespace *v1.Namespace) {
for _, volume := range t.Volumes {
tpvc, _ := volume.SetupDynamicPersistentVolumeClaim(ctx, client, namespace, t.CSIDriver, t.StorageClassParameters)
// Clean up the storageclass
defer func() {
err := client.StorageV1().StorageClasses().Delete(ctx, tpvc.storageClass.Name, metav1.DeleteOptions{})
framework.Logf("Cleanup storageclass %s, err: %v", tpvc.storageClass.Name, err)
}()

// will delete the PVC
// will also wait for PV to be deleted when reclaimPolicy=Delete
Expand Down
Loading