Skip to content

Commit

Permalink
add runOnMaster switch for helm chart
Browse files Browse the repository at this point in the history
  • Loading branch information
boddumanohar committed Feb 5, 2021
1 parent f95da24 commit d6bb078
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions charts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ The following table lists the configurable parameters of the latest SMB CSI Driv
| `windows.image.nodeDriverRegistrar.pullPolicy` | windows csi-node-driver-registrar image pull policy | IfNotPresent |
| `kubelet.linuxPath` | configure the kubelet path for Linux node | `/var/lib/kubelet` |
| `kubelet.windowsPath` | configure the kubelet path for Windows node | `'C:\var\lib\kubelet'` |
| `controller.runOnMaster` | run controller on master node | false |

## troubleshooting
- Add `--wait -v=5 --debug` in `helm install` command to get detailed error
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ spec:
serviceAccountName: csi-smb-controller-sa
nodeSelector:
kubernetes.io/os: linux
{{- if .Values.controller.runOnMaster}}
kubernetes.io/role: master
{{- end}}
priorityClassName: system-cluster-critical
tolerations:
- key: "node-role.kubernetes.io/master"
Expand Down
1 change: 1 addition & 0 deletions charts/latest/csi-driver-smb/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ rbac:
controller:
replicas: 2
metricsPort: 29644
runOnMaster: false

node:
metricsPort: 29645
Expand Down
2 changes: 1 addition & 1 deletion deploy/csi-smb-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
spec:
serviceAccountName: csi-smb-controller-sa
nodeSelector:
kubernetes.io/os: linux
kubernetes.io/os: linux #add "kubernetes.io/role: master" to run controller on master node
priorityClassName: system-cluster-critical
tolerations:
- key: "node-role.kubernetes.io/master"
Expand Down

0 comments on commit d6bb078

Please sign in to comment.