Fix cp arg expansion bug in cloning implementation #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cloning implementation for hostpath volumes used `args :=
[]string{"-a", srcPath + "/*", destPath + "/"}`
The result is some shells will actually try to find/copy a file `*` from
the source directory. We need to use the cp specific syntax for this
instead `.`, to guarantee that things work on different platforms and
shells.
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
|
/assign @msau42 |
msau42
reviewed
Jul 31, 2019
| @@ -293,7 +293,7 @@ func loadFromVolume(srcVolumeId, destPath string) error { | |||
|
|
|||
| // If the source hostpath volume is empty it's a noop and we just move along, otherwise the cp call will fail with a a file stat error DNE | |||
| if !isEmpty { | |||
| args := []string{"-a", srcPath + "/*", destPath + "/"} | |||
| args := []string{"-a", srcPath + "/.", destPath + "/"} | |||
There was a problem hiding this comment.
Nah, -a is the equivalent of -dR
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: j-griffith, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
What this PR does / why we need it:
The clone implementation is just using
cp /*can result in trying to actually find/copy a file named*. The result in some container images is a stat error for no such file or directory. Instead we should be using the cp notation of/.so we're portable and always work.Which issue(s) this PR fixes:
Fixes #81
Special notes for your reviewer:
Does this PR introduce a user-facing change?: