added the fix for script for not being able to use in script source path

[aayushrangwala]

What type of PR is this?
/kind bug

What this PR does / why we need it:
The csi driver deployment script was using the base path as the curr dir where the script is triggerred, csi-snapshot class was not getting installed because of incorrect path resolution. Fixed to use the base path always using pwd and cd

Which issue(s) this PR fixes:

Fixes ##199

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

Added the Fix for path resolution in deploy script. Now the user can run script from anywhere, not necessarily from the base path as `./deploy/kubernetes-1.1x/depploy-script.sh`

[k8s-ci-robot]

Hi @aayushrangwala. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pohly]

Do we need BASH_SOURCE here? Why not just $0?

Also, why the output redirection?

[aayushrangwala]

Well both BASH_SOURCE and $0 would serve the same purpose here just using the BASH_SOURCE in bash script is better even if it is sourced

And for output redirection, sometimes cd prints something to stdout, in the case where a CDPATH is set and even an error can be printed. So to be safe, there is the stdout redirection to dev null and stderr to stdout

To cover CDPATH weird cases, we can even follow to unset CDPATH at the begining and not use this redirection but still it will be changing user's config

[pohly]

Well both BASH_SOURCE and $0 would serve the same purpose here just using the BASH_SOURCE in bash script is better even if it is sourced

I think it is better to not depend on bash features unnecessarily, because then a conversion to a non-Bash script becomes easier. Currently pipefail is the only bashism that I am aware of, and even that may not be necessary.

And for output redirection, sometimes cd prints something to stdout

During normal operation? That's very unexpected.

in the case where a CDPATH is set and even an error can be printed.

If an error is printed, presumably the return code is non-zero, BASE_DIR is unset and everything fails. We want to see the error message of cd in that case.

[aayushrangwala]

ohkay, right. we can depend on pipefail I can ignore the output redirection

[aayushrangwala]

done

[pohly]

/lgtm

[pohly]

/approve

[pohly]

/ok-to-test

[pohly]

/assign @xing-yang

For approval.

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aayushrangwala, pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pohly,xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pohly]

/retest