-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove service from hostpath specs #170
Comments
@msau42: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Hi @msau42, As per i understand we have to remove services for sidecars yaml in hostpath and keep the service name and service account name in spec of statefulset? |
Hi @Kartik494 that's correct. |
@msau42 so the changes is to be done in all the yaml except csi-hostpath-plugin yaml ? As i see we defined the need for service there! |
/assign |
…roller prow.sh: deploy canary snapshot-controller in canary jobs
They're unnecessary and actually a random port is specified, which may not be desirable.
We got confirmation from sig-apps in kubernetes/kubernetes#69608 that this will be supported. StatefulSet is v1 now, so they cannot change the behavior without it being breaking change.
/help
/kind cleanup
The text was updated successfully, but these errors were encountered: