Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service from hostpath specs #170

Closed
msau42 opened this issue Apr 10, 2020 · 6 comments · Fixed by #196
Closed

Remove service from hostpath specs #170

msau42 opened this issue Apr 10, 2020 · 6 comments · Fixed by #196
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@msau42
Copy link
Collaborator

msau42 commented Apr 10, 2020

They're unnecessary and actually a random port is specified, which may not be desirable.

We got confirmation from sig-apps in kubernetes/kubernetes#69608 that this will be supported. StatefulSet is v1 now, so they cannot change the behavior without it being breaking change.

/help
/kind cleanup

@k8s-ci-robot
Copy link
Contributor

@msau42:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

They're unnecessary and actually a random port is specified, which may not be desirable.

We got confirmation from sig-apps in kubernetes/kubernetes#69608 that this will be supported. StatefulSet is v1 now, so they cannot change the behavior without it being breaking change.

/help
/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 10, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2020
@Kartik494
Copy link
Member

Hi @msau42, As per i understand we have to remove services for sidecars yaml in hostpath and keep the service name and service account name in spec of statefulset?

@msau42
Copy link
Collaborator Author

msau42 commented Jul 29, 2020

Hi @Kartik494 that's correct.

@Kartik494
Copy link
Member

@msau42 so the changes is to be done in all the yaml except csi-hostpath-plugin yaml ? As i see we defined the need for service there!

@Kartik494
Copy link
Member

/assign

TerryHowe pushed a commit to TerryHowe/csi-driver-host-path that referenced this issue Oct 17, 2024
…roller

prow.sh: deploy canary snapshot-controller in canary jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants