-
Notifications
You must be signed in to change notification settings - Fork 218
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The recently introduced support for tracking of staging and publishing can be improved: - Now it properly supports publishing more than once. - Mutex locking in NodeStageVolume and NodeUnstageVolume was missing. - NodeUnstageVolume and NodeUnpublishVolume can bail out early when nothing needs to be done. In the case of NodeUnpublishVolume that avoids unmounting at a path not managed by the driver. The driver cannot distinguish between an invalid path and an idempotent call, so this is not treated as an error. - NodePublishVolume checks that the staging target path is valid. - NodeStageVolume rejects staging more than once.
- Loading branch information
Showing
5 changed files
with
114 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| Copyright 2021 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package state | ||
|
|
||
| // Strings is an ordered set of strings with helper functions for | ||
| // adding, searching and removing entries. | ||
| type Strings []string | ||
|
|
||
| // Add appends at the end. | ||
| func (s *Strings) Add(str string) { | ||
| *s = append(*s, str) | ||
| } | ||
|
|
||
| // Has checks whether the string is already present. | ||
| func (s *Strings) Has(str string) bool { | ||
| for _, str2 := range *s { | ||
| if str == str2 { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| // Empty returns true if the list is empty. | ||
| func (s *Strings) Empty() bool { | ||
| return len(*s) == 0 | ||
| } | ||
|
|
||
| // Remove removes the first occurence of the string, if present. | ||
| func (s *Strings) Remove(str string) { | ||
| for i, str2 := range *s { | ||
| if str == str2 { | ||
| *s = append((*s)[:i], (*s)[i+1:]...) | ||
| return | ||
| } | ||
| } | ||
| } |