Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protosanitizer when logging #5

Merged
merged 2 commits into from
Dec 12, 2018

Conversation

lpabon
Copy link
Member

@lpabon lpabon commented Dec 12, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpabon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2018
@pohly
Copy link
Contributor

pohly commented Dec 12, 2018

The number of imported files in this PR and in vendor in general would be a lot smaller if pruning was enabled in the repo - see kubernetes-retired/drivers#127.

I know it's unrelated to this PR, but perhaps you can add it here anyway?

@lpabon
Copy link
Member Author

lpabon commented Dec 12, 2018

Great idea @pohly. Result: +459 −1,718,522 lines

@msau42
Copy link
Collaborator

msau42 commented Dec 12, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 719180f into kubernetes-csi:master Dec 12, 2018
@msau42
Copy link
Collaborator

msau42 commented Dec 12, 2018

@lpabon can you also cherry pick to release 1.0

@msau42
Copy link
Collaborator

msau42 commented Jan 15, 2019

pohly pushed a commit to pohly/cluster-driver-registrar that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants