Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-base ref to include yaml security fix #724

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Update python-base ref to include yaml security fix #724

merged 1 commit into from
Jan 14, 2019

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Jan 11, 2019

Update the python-base submodule to ship kubernetes-client/python-base#111

Tested it with a kubeconfig file specifying a client-certificate and a certificate-authority, no regression detected.

As this addresses a security issue, I think it deserves a 8.0.2 release. What would be the process to cherry-pick it and get a release?

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 11, 2019
@xvello
Copy link
Contributor Author

xvello commented Jan 14, 2019

@yliaog As you approved the sister PR, could you please take a look at this one?

As this addresses a security issue, I think it deserves a 8.0.2 release. What would be the process to cherry-pick it and get a release?

@yliaog
Copy link
Contributor

yliaog commented Jan 14, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xvello, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2019
@yliaog
Copy link
Contributor

yliaog commented Jan 14, 2019

/cc @roycaihw for cherrypick/release

@k8s-ci-robot k8s-ci-robot requested a review from roycaihw January 14, 2019 19:56
@k8s-ci-robot
Copy link
Contributor

@yliaog: GitHub didn't allow me to request PR reviews from the following users: for, cherrypick/release.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @roycaihw for cherrypick/release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit ed18ea8 into kubernetes-client:master Jan 14, 2019
@xvello
Copy link
Contributor Author

xvello commented Jan 28, 2019

hi @roycaihw
Any chance we could cut a release (either 8.0.2 or 9.0.0 if ready) with this security fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants