Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pep8 into pycodestyle since pep8 is depreciated #667

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

micw523
Copy link
Contributor

@micw523 micw523 commented Oct 27, 2018

This PR fixes #666 - pep8 package has changed its name to pycodestyle.
This PR will come along with another PR from kubernetes/base.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 27, 2018
@micw523
Copy link
Contributor Author

micw523 commented Oct 27, 2018

/cc @roycaihw

@k8s-ci-robot k8s-ci-robot requested a review from roycaihw October 27, 2018 07:40
@yliaog
Copy link
Contributor

yliaog commented Oct 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2018
@roycaihw
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micw523, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit 529c0d3 into kubernetes-client:master Oct 29, 2018
@micw523 micw523 deleted the k8s_pep8 branch November 1, 2018 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis CI - pep8 is depreciated
4 participants