config: Fix persist_config flag and function calls

[jfrabaute]

The persist_config flag was setting the kwargs['config_persister'] to
the result of the function kcfg.save_changes and not the function
kcfg.save_changes itself.

Once this is fixed, the second problem was that the function was called
with an argument when it's defined without argument so an exception was
raised.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@7ea5cb4). Click here to learn what that means.
The diff coverage is 80%.

@@            Coverage Diff            @@
##             master     #169   +/-   ##
=========================================
  Coverage          ?   92.52%           
=========================================
  Files             ?       13           
  Lines             ?     1485           
  Branches          ?        0           
=========================================
  Hits              ?     1374           
  Misses            ?      111           
  Partials          ?        0

Impacted Files	Coverage Δ
config/kube_config_test.py	95.66% <100%> (ø)
config/kube_config.py	84.25% <25%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea5cb4...64662bb. Read the comment docs.

[yliaog]

please sign cla
please add a test to verify the fix

[jfrabaute]

CLA signed

[jfrabaute]

Hi @yliaog

Regarding the test, from what I understand from the code, the problem is in the function "get_kube_config_loader_for_yaml_file" (this is where the fix is).
Should I add a test for this function? I'm asking because as it has a "" it might just be a private function that should not be tested. The problem is that I can't find another way to test it as calling, as calling other functions using this one does not allow me to check that _config_persister is set correctly in the KubeConfigLoader object.
So, is that ok to add a test for "_get_kube_config_loader_for_yaml_file"?

Thanks.

[jfrabaute]

I've added 2 tests for the "_get_kube_config_loader_for_yaml_file" function.
Keep me posted if that's correct or not.

Thanks.

[jfrabaute]

Hi

Any news about reviewing this PR?

Thanks.

[roycaihw]

/kind bug
/lgtm
/approve

Thanks for sending the fix!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jfrabaute, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment