Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of sudo to install tar #963

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

johscheuer
Copy link
Contributor

Signed-off-by: Johannes M. Scheuermann [email protected]
This PR: #893 introduced a change to make the gobetween script also be usable on CentOS, sadly this breaks the ubuntu setup (since ubuntu uses the ubuntu user and not root):

openstack_compute_instance_v2.lb (remote-exec):   Checking Host Key: false
openstack_compute_instance_v2.lb: Still creating... [50s elapsed]
openstack_compute_instance_v2.lb (remote-exec): Connected!
openstack_compute_instance_v2.lb (remote-exec): E: Could not open lock file /var/lib/dpkg/lock-frontend - open (13: Permission denied)
openstack_compute_instance_v2.lb (remote-exec): E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), are you root?

What this PR does / why we need it:
Without this PR the provisioning of new clusters will fail with the error message from above.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix recursion bug in gobetween.sh script

Signed-off-by: Johannes M. Scheuermann <[email protected]>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2020
@kubermatic-bot
Copy link
Contributor

Hi @johscheuer. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2020
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💯 👍

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7e1862e9def132629bbf786a714553b5b8f3ed27

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johscheuer, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
@xmudrii
Copy link
Member

xmudrii commented Jul 9, 2020

/test all

@kron4eg
Copy link
Member

kron4eg commented Jul 9, 2020

/retest

@kubermatic-bot kubermatic-bot merged commit ef21e66 into kubermatic:master Jul 9, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone Jul 9, 2020
@johscheuer johscheuer deleted the fix-gobetween-script branch July 9, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants