Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1beta1 API in E2E tests #917

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Use v1beta1 API in E2E tests #917

merged 1 commit into from
Jun 8, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jun 2, 2020

What this PR does / why we need it:

Use the v1beta1 API for E2E tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #828

Does this PR introduce a user-facing change?:

NONE

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg June 2, 2020 12:18
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 2, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2020
@xmudrii xmudrii force-pushed the v1beta1-api-e2e branch from fb4f48b to b85bbb6 Compare June 2, 2020 12:24
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2020
@xmudrii xmudrii force-pushed the v1beta1-api-e2e branch from b85bbb6 to 1de04c2 Compare June 8, 2020 13:05
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Jun 8, 2020

@kron4eg All comments addressed, PTAL

@xmudrii xmudrii requested a review from kron4eg June 8, 2020 13:05
@xmudrii xmudrii force-pushed the v1beta1-api-e2e branch from 1de04c2 to 572fe67 Compare June 8, 2020 13:13
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2b4ec48534d3fad71fc057d047087f557533afc7

@kubermatic-bot kubermatic-bot merged commit db44f5a into master Jun 8, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone Jun 8, 2020
@kubermatic-bot kubermatic-bot deleted the v1beta1-api-e2e branch June 8, 2020 14:04
@kron4eg kron4eg mentioned this pull request Jun 8, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants