Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind docker-ce-cli to the same version as docker-ce #896

Merged
merged 2 commits into from
May 19, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 19, 2020

What this PR does / why we need it:

This PR binds the docker-ce-cli package to the same version as the docker-ce package. This fixes the incompatibilities between CLI and daemon, causing provisioning to fail.

Before this fix, we were getting the following error when trying to provision the cluster:

Server:
ERROR: Error response from daemon: client version 1.40 is too new. Maximum supported API version is 1.39

This error was present at the Running kubeadm phase. It was happening because the latest Docker CLI requires the daemon supporting API version 1.40 or newer.

Does this PR introduce a user-facing change?:

Bind docker-ce-cli to the same version as docker-ce. This fixes the cluster provisioning failures.

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg May 19, 2020 10:22
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels May 19, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f0b64c4d6afefc2430b7be6989cdb6de18e3d34d

@xmudrii
Copy link
Member Author

xmudrii commented May 19, 2020

/retest

@xmudrii
Copy link
Member Author

xmudrii commented May 19, 2020

/hold
to prevent automatic retest. Quay is currently down, so it's not possible to pull the CNI image, causing all tests to fail

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2020
@xmudrii
Copy link
Member Author

xmudrii commented May 19, 2020

/retest

@xmudrii
Copy link
Member Author

xmudrii commented May 19, 2020

/override pull-kubeone-e2e-aws-conformance-1.16
/override pull-kubeone-e2e-aws-conformance-1.17
/override pull-kubeone-e2e-aws-conformance-1.18

@xmudrii
Copy link
Member Author

xmudrii commented May 19, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2020
@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-aws-conformance-1.16, pull-kubeone-e2e-aws-conformance-1.17, pull-kubeone-e2e-aws-conformance-1.18

In response to this:

/override pull-kubeone-e2e-aws-conformance-1.16
/override pull-kubeone-e2e-aws-conformance-1.17
/override pull-kubeone-e2e-aws-conformance-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 2d93813 into master May 19, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone May 19, 2020
@kubermatic-bot kubermatic-bot deleted the docker-cli-version branch May 19, 2020 17:12
@kron4eg
Copy link
Member

kron4eg commented May 20, 2020

/cherrypick release/v0.11

@kubermatic-bot
Copy link
Contributor

@kron4eg: #896 failed to apply on top of branch "release/v0.11":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/scripts/os.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/scripts/os.go
CONFLICT (content): Merge conflict in pkg/scripts/os.go
Patch failed at 0001 Bind docker-ce-cli to the same version as docker-ce

In response to this:

/cherrypick release/v0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants