Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update machine-controller to v1.11.1 #808

Merged
merged 5 commits into from
Mar 24, 2020
Merged

Update machine-controller to v1.11.1 #808

merged 5 commits into from
Mar 24, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Feb 25, 2020 •
edited
Loading

What this PR does / why we need it:

  • Update machine-controller to v1.11.1
  • Enable NodeCSRApprover controller
  • Use machine-controller Cluster-API types and drop the Cluster-API dependency
  • Update machine-controller types
  • Update Terraform examples

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #805

Does this PR introduce a user-facing change?:

Update `machine-controller` to v1.11.1
Enable NodeCSRApprover controller
Use `machine-controller` Cluster-API types and drop the Cluster-API dependency
Update `machine-controller` types
Update Terraform examples

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg February 25, 2020 10:47
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Feb 25, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Feb 25, 2020

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Feb 25, 2020

/retest

@xmudrii xmudrii changed the title Update machine-controller to v1.10.2 and update API types [WIP] Update machine-controller to v1.11.0 Mar 19, 2020
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Mar 19, 2020

/hold

@xmudrii xmudrii changed the title [WIP] Update machine-controller to v1.11.0 [WIP] Update machine-controller to v1.11.1 Mar 20, 2020
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2020
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 24, 2020
@xmudrii xmudrii changed the title [WIP] Update machine-controller to v1.11.1 Update machine-controller to v1.11.1 Mar 24, 2020
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Mar 24, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cde727a9a660219f19b1620d9e2d9d5422cbd3e9

@kron4eg kron4eg removed the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cde727a9a660219f19b1620d9e2d9d5422cbd3e9

@kron4eg
Copy link
Member

kron4eg commented Mar 24, 2020

/hold

we need to figure out something about those E2E

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Mar 24, 2020

/override pull-kubeone-e2e-openstack-conformance-1.16
/override pull-kubeone-e2e-openstack-conformance-1.17
/override pull-kubeone-e2e-openstack-upgrade-1.15-1.16
/override pull-kubeone-e2e-openstack-upgrade-1.16-1.17
/override pull-kubeone-e2e-gce-upgrade-1.15-1.16
/override pull-kubeone-e2e-gce-conformance-1.16
/override pull-kubeone-e2e-gce-conformance-1.15
/override pull-kubeone-e2e-hetzner-conformance-1.17
/override pull-kubeone-e2e-gce-upgrade-1.16-1.17
/override pull-kubeone-e2e-gce-conformance-1.17
/override pull-kubeone-e2e-packet-conformance-1.16
/override pull-kubeone-e2e-packet-conformance-1.17
/override pull-kubeone-e2e-packet-upgrade-1.15-1.16
/override pull-kubeone-e2e-packet-conformance-1.15
/override pull-kubeone-e2e-packet-upgrade-1.16-1.17

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-gce-conformance-1.15, pull-kubeone-e2e-gce-conformance-1.16, pull-kubeone-e2e-gce-conformance-1.17, pull-kubeone-e2e-gce-upgrade-1.15-1.16, pull-kubeone-e2e-gce-upgrade-1.16-1.17, pull-kubeone-e2e-hetzner-conformance-1.17, pull-kubeone-e2e-openstack-conformance-1.16, pull-kubeone-e2e-openstack-conformance-1.17, pull-kubeone-e2e-openstack-upgrade-1.15-1.16, pull-kubeone-e2e-openstack-upgrade-1.16-1.17, pull-kubeone-e2e-packet-conformance-1.15, pull-kubeone-e2e-packet-conformance-1.16, pull-kubeone-e2e-packet-conformance-1.17, pull-kubeone-e2e-packet-upgrade-1.15-1.16, pull-kubeone-e2e-packet-upgrade-1.16-1.17

In response to this:

/override pull-kubeone-e2e-openstack-conformance-1.16
/override pull-kubeone-e2e-openstack-conformance-1.17
/override pull-kubeone-e2e-openstack-upgrade-1.15-1.16
/override pull-kubeone-e2e-openstack-upgrade-1.16-1.17
/override pull-kubeone-e2e-gce-upgrade-1.15-1.16
/override pull-kubeone-e2e-gce-conformance-1.16
/override pull-kubeone-e2e-gce-conformance-1.15
/override pull-kubeone-e2e-hetzner-conformance-1.17
/override pull-kubeone-e2e-gce-upgrade-1.16-1.17
/override pull-kubeone-e2e-gce-conformance-1.17
/override pull-kubeone-e2e-packet-conformance-1.16
/override pull-kubeone-e2e-packet-conformance-1.17
/override pull-kubeone-e2e-packet-upgrade-1.15-1.16
/override pull-kubeone-e2e-packet-conformance-1.15
/override pull-kubeone-e2e-packet-upgrade-1.16-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented Mar 24, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
@kubermatic-bot kubermatic-bot merged commit 886cca7 into master Mar 24, 2020
@kubermatic-bot kubermatic-bot added this to the v0.12 milestone Mar 24, 2020
@kubermatic-bot kubermatic-bot deleted the mc-1.10.2 branch March 24, 2020 17:51
@xmudrii
Copy link
Member Author

xmudrii commented Apr 1, 2020

/cherrypick release/v0.11

@kubermatic-bot kubermatic-bot mentioned this pull request Apr 1, 2020
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #851

In response to this:

/cherrypick release/v0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.12
Development

Successfully merging this pull request may close these issues.

[vSphere] Update machine-controller version to include datastore cluster support
3 participants
@xmudrii @kubermatic-bot @kron4eg