Upgrade controller-runtime to v0.3.0 #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
|
/hold hack with cache drop (resolved upstream) to be removed |
kubermatic-bot
added
the
do-not-merge/hold
|
/hold cancel |
kubermatic-bot
removed
the
do-not-merge/hold
xmudrii
reviewed
Oct 23, 2019
kron4eg
force-pushed
the
controller-runtime-0.3
branch
from
dd64851 to
bed0d50
Compare
* Upstream k8s libs are updated to kubernetes-1.15.4 release tag * Fixed many API breaking changes * Logic regarding checking version of CCM is removed Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
* upstream issue kubernetes-sigs/controller-runtime#321 Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
This reverts commit 73710af. Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
kron4eg
force-pushed
the
controller-runtime-0.3
branch
from
bed0d50 to
00fd634
Compare
xmudrii
approved these changes
Oct 23, 2019
There was a problem hiding this comment.
Looks great! 💯
As a follow-up, should we comment on kubernetes-sigs/controller-runtime#321 or create a new upstream issue?
/lgtm
|
LGTM label has been added. Git tree hash: eafc1f7d3e7e3062a75cbaffbd2b0bff92d39648
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Takes advantage of newer and better controller-runtime APIs
Special notes for your reviewer:
Does this PR introduce a user-facing change?: