Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better flannel configuration #598

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Better flannel configuration #598

merged 1 commit into from
Jul 25, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jul 22, 2019

What this PR does / why we need it:
When private network is available, it should be used for internal CNI communications.

Force flannel to use internal network when available

@kron4eg kron4eg requested a review from xmudrii July 22, 2019 15:09
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2019
@xmudrii
Copy link
Member

xmudrii commented Jul 22, 2019

/hold
/test pull-kubeone-e2e-digitalocean-upgrade-1.13-1.14

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2019
xmudrii
xmudrii approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c5efc57051d07c075f87f9596b4a3c725adaa11d

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Jul 24, 2019

/test pull-kubeone-e2e-hetzner-conformance-1.15

@kron4eg
Copy link
Member Author

kron4eg commented Jul 24, 2019

/test pull-kubeone-e2e-digitalocean-conformance-1.15

@kron4eg
Copy link
Member Author

kron4eg commented Jul 24, 2019

/retest

xmudrii
xmudrii approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 35472eb85ca9f4cf22eff0723e1834891a0be0a9

@xmudrii
Copy link
Member

xmudrii commented Jul 24, 2019

/pull pull-kubeone-e2e-digitalocean-conformance-1.15

@kron4eg
Copy link
Member Author

kron4eg commented Jul 24, 2019

/test pull-kubeone-e2e-hetzner-conformance-1.15

@xmudrii
Copy link
Member

xmudrii commented Jul 24, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.14-1.15

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2019
@xmudrii
Copy link
Member

xmudrii commented Jul 24, 2019

/retest

1 similar comment
@kron4eg
Copy link
Member Author

kron4eg commented Jul 24, 2019

/retest

@kron4eg
Patch CNI (Flannel) when external CCM is working
5e0fe44 
* add FLANNELD_IFACE = status.hostIP env to flannel
* when external CCM is deployed, wait for Nodes to be initialized
* introduced new package clientutil
* removed all simpleCreateOrUpdate and placed with clientutil.CreateOrUpdate
* FIX UPDATES of the objects
* removed TypeMeta
* group kubernetes objects to be deployed into packs

Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Copy link
Member Author

kron4eg commented Jul 24, 2019

/retest

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jul 24, 2019 •
edited
Loading

@kron4eg: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-digitalocean-upgrade-1.13-1.14 98e7dd7 link /test pull-kubeone-e2e-digitalocean-upgrade-1.13-1.14

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kron4eg
Copy link
Member Author

kron4eg commented Jul 24, 2019

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Jul 24, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.14-1.15
/test pull-kubeone-e2e-hetzner-upgrade-1.14-1.15

@kron4eg
Copy link
Member Author

kron4eg commented Jul 24, 2019

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2019
@xmudrii
Copy link
Member

xmudrii commented Jul 25, 2019

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Jul 25, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b397032c57471ebce00efd89ff59adbd9a815ab1

@kubermatic-bot kubermatic-bot merged commit cb97908 into master Jul 25, 2019
@kubermatic-bot kubermatic-bot deleted the flannel_config branch July 25, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @xmudrii @kubermatic-bot