Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade machinecontroller to v1.2.0 #490

Merged
merged 3 commits into from
Jun 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions Gopkg.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ required = [

[[constraint]]
name = "sigs.k8s.io/cluster-api"
revision = "c63bf6f67ab631a449b6eb76dfe29458441051e0"
revision = "2ec456177c0e8f0a903f4e746d44baaae54cc591"

[[constraint]]
name = "sigs.k8s.io/controller-runtime"
Expand All @@ -74,6 +74,3 @@ required = [
non-go = false
go-tests = false
unused-packages = false
[[constraint]]
name = "github.com/cpuguy83/go-md2man"
revision = "691ee98543af2f262f35fbb54bdd42f00b9b9cc5"
3 changes: 3 additions & 0 deletions pkg/cmd/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,9 @@ machineController:
# Proxy is used to configure HTTP_PROXY, HTTPS_PROXY and NO_PROXY
# for Docker daemon and kubelet, and to be used when provisioning cluster
# (e.g. for curl, apt-get..).
# Also worker nodes managed by machine-controller will be configred according to
# proxy settings here. The caveat is that only proxy.http and proxy.noProxy will
# be used on worker machines.
# proxy:
# http: '{{ .HTTPProxy }}'
# https: '{{ .HTTPSProxy }}'
Expand Down
10 changes: 9 additions & 1 deletion pkg/templates/machinecontroller/deployment.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const (
MachineControllerNamespace = metav1.NamespaceSystem
MachineControllerAppLabelKey = "app"
MachineControllerAppLabelValue = "machine-controller"
MachineControllerTag = "v1.1.9"
MachineControllerTag = "v1.2.0"
)

// Deploy deploys MachineController deployment with RBAC on the cluster
Expand Down Expand Up @@ -727,6 +727,14 @@ func machineControllerDeployment(cluster *kubeoneapi.KubeOneCluster) (*appsv1.De
"-cluster-dns", clusterDNS.String(),
}

if cluster.Proxy.HTTP != "" {
args = append(args, "-node-http-proxy", cluster.Proxy.HTTP)
}

if cluster.Proxy.NoProxy != "" {
args = append(args, "-node-no-proxy", cluster.Proxy.NoProxy)
}

if cluster.CloudProvider.External {
args = append(args, "-external-cloud-provider")
}
Expand Down
13 changes: 13 additions & 0 deletions vendor/sigs.k8s.io/cluster-api/logos/LICENSE.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.