Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flag to skip TLS verification #3522

Merged
merged 2 commits into from
Jan 6, 2025
Merged

feat: add flag to skip TLS verification #3522

merged 2 commits into from
Jan 6, 2025

Conversation

steled
Copy link
Contributor

@steled steled commented Jan 3, 2025 •
edited by kubermatic-bot
Loading

What this PR does / why we need it:
Add possibility to skip TLS verification for self-signed certificates.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add parameter `insecure` to the `backups-restic` addon used to disable/skip the TLS verification

Documentation:

existing doc: https://docs.kubermatic.com/kubeone/v1.9/examples/addons-backup/
PR: https://github.com/kubermatic/docs/pull/1807

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2025
@kubermatic-bot
Copy link
Contributor

Hi @steled. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 3, 2025
@steled @kron4eg
Update addons/backups-restic/backups-restic.yaml
9cdeb34 
Co-authored-by: Artiom Diomin <[email protected]>
Signed-off-by: Stephan <[email protected]>
@steled
Copy link
Contributor Author

steled commented Jan 6, 2025 •
edited
Loading

I also updated the documentation at: kubermatic/docs#1807

@kron4eg
Copy link
Member

kron4eg commented Jan 6, 2025

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3a4801f9b1c8d871e6e363ed7bdef6b38ff30f9e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@kron4eg kron4eg mentioned this pull request Jan 6, 2025
Merged
@kron4eg
Copy link
Member

kron4eg commented Jan 6, 2025

/hold

waiting #3523 to merge

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2025
@kron4eg
Copy link
Member

kron4eg commented Jan 6, 2025

/retest

@kron4eg
Copy link
Member

kron4eg commented Jan 6, 2025

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2025
@kubermatic-bot kubermatic-bot merged commit f614f72 into kubermatic:main Jan 6, 2025
13 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.10 milestone Jan 6, 2025
xmudrii pushed a commit that referenced this pull request Jan 30, 2025
@steled @kron4eg @xmudrii
feat: add flag to skip TLS verification (#3522)
266c6fc 
* feat: add flag to skip TLS verification

Signed-off-by: Stephan <[email protected]>

* Update addons/backups-restic/backups-restic.yaml

Co-authored-by: Artiom Diomin <[email protected]>
Signed-off-by: Stephan <[email protected]>

---------

Signed-off-by: Stephan <[email protected]>
Co-authored-by: Artiom Diomin <[email protected]>
@xmudrii
Copy link
Member

xmudrii commented Jan 30, 2025

/release-note-edit

Add parameter `insecure` to the `backups-restic` addon used to disable/skip the TLS verification

@xmudrii xmudrii mentioned this pull request Jan 30, 2025
Merged
kubermatic-bot pushed a commit that referenced this pull request Jan 30, 2025
@xmudrii @steled
@kron4eg @mohamed-rafraf
[release/v1.9] Cherry-pick the required fixes for the release/v1.9 …
d807014 
…branch (#3547)

* feat: add flag to skip TLS verification (#3522)

* feat: add flag to skip TLS verification

Signed-off-by: Stephan <[email protected]>

* Update addons/backups-restic/backups-restic.yaml

Co-authored-by: Artiom Diomin <[email protected]>
Signed-off-by: Stephan <[email protected]>

---------

Signed-off-by: Stephan <[email protected]>
Co-authored-by: Artiom Diomin <[email protected]>

* fix cloud config defaulting before terraform config apply (#3534)

* Make sure no slash at the end of vcenterPrefix (#3537)

Signed-off-by: Artiom Diomin <[email protected]>

* Fix kubevirt csi addon template (#3529)

* fix kubevirt csi addon template

* update internal images in template

* update internal images in template

* fix labels

* update addons

* update addons sa

* fix toleration (#3545)

* update Machine controller image (#3546)

* update Machine controller image

Signed-off-by: Mohamed Rafraf <[email protected]>

* update go.mod

---------

Signed-off-by: Mohamed Rafraf <[email protected]>

* labeling control-plane before (#3544)

---------

Signed-off-by: Stephan <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Mohamed Rafraf <[email protected]>
Co-authored-by: Stephan <[email protected]>
Co-authored-by: Artiom Diomin <[email protected]>
Co-authored-by: Mohamed Rafraf <[email protected]>
Co-authored-by: Artiom Diomin <[email protected]>
@xmudrii
Copy link
Member

xmudrii commented Feb 5, 2025

/cherrypick release/v1.8

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3554

In response to this:

/cherrypick release/v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg left review comments

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@steled @kubermatic-bot @kron4eg @xmudrii