Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete install and upgrade subcommand #3349

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Delete install and upgrade subcommand #3349

merged 1 commit into from
Aug 14, 2024

Conversation

mohamed-rafraf
Copy link
Member

@mohamed-rafraf mohamed-rafraf commented Aug 14, 2024 •
edited
Loading

What this PR does / why we need it:
This PR will delete the deprecated subcommands: upgrade and install
Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind cleanup
Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

[ACTION REQUIRED] `kubeone install` and `kubeone upgrade` commands are removed. We have deprecated those commands in KubeOne 1.4, and made them hidden in KubeOne 1.5. With this change, we're permanently removing these two commands. `kubeone apply` should be used instead.

Documentation:

* Delete `upgrade` subcommand
* Delete `install` subcommand

@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2024
@mohamed-rafraf
Copy link
Member Author

/assign
/cc @kron4eg

@kubermatic-bot kubermatic-bot requested a review from kron4eg August 14, 2024 13:23
@mohamed-rafraf
Copy link
Member Author

/retest

@mohamed-rafraf mohamed-rafraf force-pushed the delete-install-upgrade branch from 0b1074c to 26e3e96 Compare August 14, 2024 14:41
@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 14, 2024
xmudrii
xmudrii approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5f51b5bdac4f8975f5fc8c3964006e1c7b99fdf7

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@kubermatic-bot kubermatic-bot merged commit d75dfe6 into kubermatic:main Aug 14, 2024
13 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.9 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@xmudrii xmudrii

@mohamed-rafraf mohamed-rafraf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@mohamed-rafraf @kubermatic-bot @xmudrii