add "version" command to display git version string #221
Conversation
kubermatic-bot
added
release-note
|
/assign @xmudrii |
| Long: `Prints the exact version number, as embedded by the build system.`, | ||
| Args: cobra.ExactArgs(0), | ||
| RunE: func(_ *cobra.Command, args []string) error { | ||
| fmt.Printf("KubeOne %s\n", versionString) |
There was a problem hiding this comment.
What do you think about using JSON here like kubectl does? You might lose some readability, but it's much better if you're running KubeOne using scripts and want to quickly parse version. We can also build on base of that so users can use Go to check version.
There was a problem hiding this comment.
We can add a --json parameter later if we end up needing it.
|
/retest |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 964daa3cdc536237f771108b920def39806efd66
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
What this PR does / why we need it:
Fixes #216