Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy kubeconfig to HOME and stop using kubectl with sudo #178

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jan 21, 2019

What this PR does / why we need it:

  • Adds a new installation step to copy kubeconfig on all nodes to $HOME/.kube/config
  • Use $HOME/.kube/config as default kubeconfig
  • Stop running kubectl with sudo

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #171

Release note:

NONE

@xmudrii xmudrii requested review from kron4eg and xrstf January 21, 2019 14:25
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 21, 2019
@kron4eg
Copy link
Member

kron4eg commented Jan 21, 2019

/lgtm

leaving approve for @xrstf

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ee9036c1de6a04e42d37acdcc72278d9b08132f

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2019
@xrstf
Copy link
Contributor

xrstf commented Jan 21, 2019

Less sudo is always good.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2019
@kubermatic-bot kubermatic-bot merged commit 3ec5c69 into master Jan 21, 2019
@kubermatic-bot kubermatic-bot deleted the sudo branch January 21, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy kubeconfig to .kube/config instead of running kubectl with sudo
4 participants