Add validation for cluster_name #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
LGTM label has been added. Git tree hash: f79ebe50bc312f5f2c16732c69c09b78aa8ade33
|
|
/retest |
1 similar comment
|
/retest |
cedi
pushed a commit
to cedi/kubeone
that referenced
this pull request
Nov 23, 2021
This commit fixes an rather annoying issue where `ValidateName` does not print the correct value of the invalid cluster name which made the issue hard to debug. Background: I recently upgraded from an earlier KubeOne version to master and my cluster-name contained dots (`.`). However since kubermatic#1641 this is no longer valid. The output of this validation looked like ```bash $ kubeone apply --manifest kubeone.yaml --credentials credentials.yaml --tfjson output.json --auto-approve --verbose Error: failed to initialize State: failed to build state: failed to load cluster: unable to load a given KubeOneCluster object: unable to validate the given KubeOneCluster object: name: Invalid value: "": .name should be lowercase and can only contain alphanumeric characters and hyphens(-) ``` With this commit in place the output looks like this: ```bash $ kubeone install --manifest kubeone.yaml --credentials credentials.yaml --tfjson output.json --verbose Error: failed to initialize State: failed to build state: failed to load cluster: unable to load a given KubeOneCluster object: unable to validate the given KubeOneCluster object: name: Invalid value: "k8s.cedi.dev": .name should be lowercase and can only contain alphanumeric characters and hyphens(-) ``` Signed-off-by: Cedric Kienzler <[email protected]>
kubermatic-bot
pushed a commit
that referenced
this pull request
Nov 23, 2021
…lue (#1646) This commit fixes an rather annoying issue where `ValidateName` does not print the correct value of the invalid cluster name which made the issue hard to debug. Background: I recently upgraded from an earlier KubeOne version to master and my cluster-name contained dots (`.`). However since #1641 this is no longer valid. The output of this validation looked like ```bash $ kubeone apply --manifest kubeone.yaml --credentials credentials.yaml --tfjson output.json --auto-approve --verbose Error: failed to initialize State: failed to build state: failed to load cluster: unable to load a given KubeOneCluster object: unable to validate the given KubeOneCluster object: name: Invalid value: "": .name should be lowercase and can only contain alphanumeric characters and hyphens(-) ``` With this commit in place the output looks like this: ```bash $ kubeone install --manifest kubeone.yaml --credentials credentials.yaml --tfjson output.json --verbose Error: failed to initialize State: failed to build state: failed to load cluster: unable to load a given KubeOneCluster object: unable to validate the given KubeOneCluster object: name: Invalid value: "k8s.cedi.dev": .name should be lowercase and can only contain alphanumeric characters and hyphens(-) ``` Signed-off-by: Cedric Kienzler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add validation for
cluster_namevariableWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1630
Special notes for your reviewer:
Does this PR introduce a user-facing change?: