Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.3] Quality of Life (QOL) changes #1628

Merged
merged 5 commits into from
Nov 17, 2021
Merged

[release/v1.3] Quality of Life (QOL) changes #1628

merged 5 commits into from
Nov 17, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 17, 2021

What this PR does / why we need it:

Manual cherry-pick of #1627 to the release/v1.3 branch.

Does this PR introduce a user-facing change?:

Replace critical-pod annotation with priorityClassName
Show warning about LBs on CCM migration for OpenStack clusters
Force drain nodes to remove standalone pods
Check for minor version when choosing kubeadm API version
Create MachineDeployments only for newly-provisioned clusters

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg November 17, 2021 15:37
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 17, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2021
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fcda0dab162bebad60dd8241c084053a56b6e67c

@kubermatic-bot kubermatic-bot merged commit 7ec27de into release/v1.3 Nov 17, 2021
@kubermatic-bot kubermatic-bot deleted the qol-changes-1.3 branch November 17, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg