Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warning for PodSecurityPolicies #1595

Merged
merged 8 commits into from
Oct 28, 2021
Merged

Add deprecation warning for PodSecurityPolicies #1595

merged 8 commits into from
Oct 28, 2021

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
Add deprecation warning for PodSecurityPolicies

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1308

Special notes for your reviewer:
@kron4eg right now this will show a warning when the features are getting installed. Should we should this warning at an earlier stage?

Does this PR introduce a user-facing change?:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2021
@kubermatic-bot kubermatic-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2021
@ahmedwaleedmalik
Copy link
Member Author

/test pull-kubeone-test

embik
embik approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
xmudrii
xmudrii requested changes Oct 27, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer doing this at the very beginning, because in this case, the warning can be very easy to miss, especially if you run with verbose.

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@ahmedwaleedmalik
Copy link
Member Author

I prefer doing this at the very beginning, because in this case, the warning can be very easy to miss, especially if you run with verbose.

Completely agreed, I think the warning should be shown before anything. I'll update this in a bit

@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2021
@ahmedwaleedmalik
Copy link
Member Author

/retest

@ahmedwaleedmalik
Copy link
Member Author

/retest

1 similar comment
@ahmedwaleedmalik
Copy link
Member Author

/retest

kron4eg
kron4eg approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a48ec95c3b7f1cc9df1bdf131d4b192581d13041

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2021
@kron4eg
Copy link
Member

kron4eg commented Oct 28, 2021

/retest

@kubermatic-bot kubermatic-bot merged commit b6ae859 into master Oct 28, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Oct 28, 2021
@kubermatic-bot kubermatic-bot deleted the add-deprecation-warning-psp branch October 28, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

@embik embik Awaiting requested review from embik

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@kron4eg kron4eg

@embik embik

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging this pull request may close these issues.

Show a warning that the PodSecurityPolicy feature is deprecated
5 participants
@ahmedwaleedmalik @kubermatic-bot @kron4eg @embik @xmudrii