CCM/CSI migration support for clusters with static worker nodes #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
xrstf
reviewed
Sep 28, 2021
xrstf
reviewed
Sep 28, 2021
xrstf
reviewed
Sep 28, 2021
Signed-off-by: Marko Mudrinić <[email protected]>
Signed-off-by: Marko Mudrinić <[email protected]>
xmudrii
force-pushed
the
ccm-migration-static-workers
branch
from
7f9dff6 to
ff78b0e
Compare
|
/hold |
kubermatic-bot
added
the
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 8b748575b0e77574c63d9d4a76e2e7065d9e0768
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
kubermatic-bot
removed
the
do-not-merge/hold
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces CCM/CSI migration support for clusters with the static worker nodes. As described in #1495,
kubeadmcannot be used to handle updating kubelet configuration and flags. This is becausekubeadm init(used for control plane nodes) works differently thankubeadm join(used for static worker nodes).To mitigate that, we manually update the required files, which we already do for Docker to containerd migration.
The workflow is:
/var/lib/kubelet/config.yaml)kubeadm-flags.envfile (/var/lib/kubelet/kubeadm-flags.env)--cloud-provider=externaland remove the--cloud-configflagkubeadm-flags.envThis PR has been already tested on an OpenStack cluster.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1495
Fixes #1450
Does this PR introduce a user-facing change?: