Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for versioned images #1463

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Add support for versioned images #1463

merged 1 commit into from
Aug 20, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 20, 2021

What this PR does / why we need it:

Some components and addons, such as external CCMs and CSI drivers, have different images for different Kubernetes versions. This PR extends the package we use to handle images to select the image based on the Kubernetes version.

Does this PR introduce a user-facing change?:

NONE

/assign @kron4eg

Signed-off-by: Marko Mudrinić <[email protected]>
@xmudrii xmudrii requested a review from kron4eg August 20, 2021 09:38
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 20, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 20, 2021
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 94ff7f440b9d065929f83060f91317cab723fb67

@kubermatic-bot kubermatic-bot merged commit 92c2671 into master Aug 20, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Aug 20, 2021
@kubermatic-bot kubermatic-bot deleted the versioned-images branch August 20, 2021 10:23
hwuethrich added a commit to hwuethrich/kubeone that referenced this pull request Aug 26, 2021
* upstream/master:
  Increase the minimum Kubernetes version to v1.19 (kubermatic#1466)
  Automatically deploy CSI plugin and driver for supported providers, and add support for OpenStack Cinder CSI (kubermatic#1465)
  Add support for versioned images (kubermatic#1463)
  Add changelog for v1.3.0-alpha.1 release (kubermatic#1460)
  Use kubeadm/v1beta3 API for Kubernetes 1.22+ clusters (kubermatic#1457)
  Enable PodSecurity admission controller for 1.22 clusters (kubermatic#1456)
  Add Kubernetes 1.22 tests and remove 1.18 tests (kubermatic#1447)
  Extend restart API server script to handle failing crictl logs (kubermatic#1448)
  Remove upx from the kubeone-e2e image (kubermatic#1443)
  terraform/vsphere: Inherit firmware settings from the template VM (kubermatic#1445)
  Update machine-controller to v1.35.1 (kubermatic#1440)
  Redirect push-e2e-image job failures to the appropriate channel (kubermatic#1442)
  Update images (kubermatic#1441)
  Azure CCM (kubermatic#1438)
  Upgrade machine-controller to v1.35.0 (kubermatic#1437)
  Check if unzip is present on the current system. (kubermatic#1435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants