Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH FS #1324

Merged
merged 2 commits into from
Apr 27, 2021
Merged

SSH FS #1324

merged 2 commits into from
Apr 27, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 24, 2021

What this PR does / why we need it:
This is the extraction of sshiofs and its usage from #1316. It's needed to isolate unrelated functionality developed during main driving force of #1316 (CABundle handling).

Does this PR introduce a user-facing change?:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 24, 2021
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 24, 2021
@kron4eg kron4eg force-pushed the sshiofs branch 4 times, most recently from 1f3120d to 5504a2f Compare April 26, 2021 09:22
@kron4eg kron4eg marked this pull request as ready for review April 26, 2021 09:22
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2021
@kron4eg kron4eg requested review from xrstf and xmudrii and removed request for xrstf April 26, 2021 09:22
@kron4eg kron4eg force-pushed the sshiofs branch 3 times, most recently from 47c09bf to f234575 Compare April 26, 2021 12:37
@xmudrii
Copy link
Member

xmudrii commented Apr 26, 2021

/retest

1 similar comment
@kron4eg
Copy link
Member Author

kron4eg commented Apr 26, 2021

/retest

Signed-off-by: Artiom Diomin <[email protected]>
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bab429e91a3b0684449024366ce9f5d3560cf3f8

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 0359d72 into kubermatic:master Apr 27, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Apr 27, 2021
@kron4eg kron4eg deleted the sshiofs branch April 27, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants