Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scrape prometheus headless service for nodelocaldns #1165

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Add scrape prometheus headless service for nodelocaldns #1165

merged 1 commit into from
Nov 18, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Nov 18, 2020

What this PR does / why we need it:
xref: kubernetes/kubernetes#88412

This is port from the upstream

Add scrape prometheus headless service for nodelocaldns

@kron4eg kron4eg requested a review from xmudrii November 18, 2020 13:33
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 18, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2020
xmudrii
xmudrii approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a9933bd9193c56a57b7e34b6c05c2373f3cbb776

@kron4eg
Copy link
Member Author

kron4eg commented Nov 18, 2020

/retest

@kubermatic-bot kubermatic-bot merged commit cc31d5e into master Nov 18, 2020
@kubermatic-bot kubermatic-bot deleted the nodelocaldns-metrics-service branch November 18, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii