Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.26] Read KubeVirt infra namespace from datacenter #6964

Merged
merged 2 commits into from
Nov 4, 2024
Merged

[release/v2.26] Read KubeVirt infra namespace from datacenter #6964

merged 2 commits into from
Nov 4, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
Manual backport of #6949

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

KubeVirt: use infra namespace from datacenter configuration, if specified.

Documentation:

None

moadqassem and others added 2 commits November 4, 2024 16:16
@moadqassem @ahmedwaleedmalik
Read KubeVirt infra namespace from datacenter (kubermatic#6949)
d06e687 
* read kubevirt infra namespace from datacenter

* update swagger

* generate apis

* Refactored code

Signed-off-by: Waleed Malik <[email protected]>

* Update unit tests

Signed-off-by: Waleed Malik <[email protected]>

---------

Signed-off-by: Waleed Malik <[email protected]>
Co-authored-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik
Update k8c.io/kubermatic/v2
9db1787 
Signed-off-by: Waleed Malik <[email protected]>
@kubermatic-bot kubermatic-bot added this to the KKP 2.26 milestone Nov 4, 2024
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2024
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Nov 4, 2024
@ahmedwaleedmalik
Copy link
Member Author

/approve

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
Waseem826
Waseem826 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d3f2cdc08b3481ec984fa95af0bbaee4b9e1a463

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 5b47a80 into kubermatic:release/v2.26 Nov 4, 2024
12 of 14 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the release-v2.26/backport-6949 branch November 4, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.26
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedwaleedmalik @kubermatic-bot @Waseem826 @moadqassem