Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valuesBlock and defaultValuesBlock and their conversion #6562

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

SimonTheLeg
Copy link
Member

What this PR does / why we need it:

This PR adds makes the new fields valuesBlock and defaultValuesBlock of AppInstalls and AppDefs available in the api. In addition on POST & PUT requests for AppInstalls/AppDefs the values/defaultValues fields are being converted to their valuesBlock/defaultValuesBlock equivalent.

Which issue(s) this PR fixes:

Fixes kubermatic/kubermatic#12941

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

valuesBlock and defaultValuesBlock fields are now available via the api

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2024
@Waseem826
Copy link
Contributor

Do we still need any UI changes after this?

@Waseem826 Waseem826 added this to the KKP 2.25 milestone Feb 28, 2024
@SimonTheLeg
Copy link
Member Author

I am not 100% sure. If the UI can also handle a ValuesBlock response from the BE then I think we are already fine.

In case we need to touch the FE code: I would appreciate if we could make all PUT/POST requests also use the new valuesBlock field (but only if it is not too much work).

Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 874889ffe9c43a174c889fa2bd9875aa29ea8974

@Waseem826
Copy link
Contributor

/cc @ahmedwaleedmalik

Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Feb 28, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Feb 28, 2024
@kubermatic-bot kubermatic-bot merged commit 9f82f89 into kubermatic:main Feb 28, 2024
8 checks passed
@Waseem826
Copy link
Contributor

Waseem826 commented Feb 28, 2024

It seems like the API still uses values for applications added during cluster creation. It uses valuesBlock only for the applicationinstallation endpoint.
I added an application during cluster creation and the application installation returned values field (no valuesBlock field in response).
If I add/update an application installation later on (from cluster details page), API returns the new valuesBlock field.

@SimonTheLeg
Copy link
Member Author

oh I see. This is something I did not consider. I'll have a look at it and will write a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return the ApplicationValues as a string in the API for enabling containing comments
4 participants