-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add valuesBlock and defaultValuesBlock and their conversion #6562
Add valuesBlock and defaultValuesBlock and their conversion #6562
Conversation
Do we still need any UI changes after this? |
I am not 100% sure. If the UI can also handle a ValuesBlock response from the BE then I think we are already fine. In case we need to touch the FE code: I would appreciate if we could make all PUT/POST requests also use the new valuesBlock field (but only if it is not too much work). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 874889ffe9c43a174c889fa2bd9875aa29ea8974
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, Waseem826 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It seems like the API still uses |
oh I see. This is something I did not consider. I'll have a look at it and will write a fix. |
What this PR does / why we need it:
This PR adds makes the new fields valuesBlock and defaultValuesBlock of AppInstalls and AppDefs available in the api. In addition on POST & PUT requests for AppInstalls/AppDefs the values/defaultValues fields are being converted to their valuesBlock/defaultValuesBlock equivalent.
Which issue(s) this PR fixes:
Fixes kubermatic/kubermatic#12941
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: