Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for edge provider in KKP API #6525

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Support for edge provider in KKP API #6525

merged 3 commits into from
Feb 19, 2024

Conversation

moadqassem
Copy link
Member

@moadqassem moadqassem commented Feb 15, 2024 •
edited by ahmedwaleedmalik
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Support for edge provider in KKP API

Documentation:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. sig/api Denotes a PR or issue as being assigned to SIG API. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2024
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b2db77bebc58ea32a435a635fec530c5f6bdcf90

@Waseem826
Copy link
Contributor

/lgtm
Sorry I approved too soon 😅

@ahmedwaleedmalik
Fixes
4ffbe4b 
Signed-off-by: Waleed Malik <[email protected]>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2024
@ahmedwaleedmalik
Refactored code
faf45be 
Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik ahmedwaleedmalik changed the title WIP: Support edge provider in the api Support edge provider in the api Feb 16, 2024
@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Feb 16, 2024
@ahmedwaleedmalik ahmedwaleedmalik changed the title Support edge provider in the api Support for edge provider in KKP API Feb 16, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 16, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ec6fd9d5b72e33ce0a67e9f5d648a549698a6aa0

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2024
@moadqassem
Copy link
Member Author

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2024
@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Feb 16, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Feb 16, 2024
@moadqassem
Copy link
Member Author

/retest

@moadqassem
Copy link
Member Author

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2024
@kubermatic-bot kubermatic-bot merged commit 5f521be into kubermatic:main Feb 19, 2024
8 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.25 milestone Feb 19, 2024
@moadqassem moadqassem deleted the support-edge-provider branch February 19, 2024 12:10
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@Waseem826 Waseem826 Awaiting requested review from Waseem826

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.
4 participants
@moadqassem @kubermatic-bot @Waseem826 @ahmedwaleedmalik