Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set LoadBalancerSKU from Azure preset #6506

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Set LoadBalancerSKU from Azure preset #6506

merged 1 commit into from
Feb 10, 2024

Conversation

embik
Copy link
Member

@embik embik commented Feb 9, 2024

What this PR does / why we need it:
Looks like the preset-to-spec logic never set the load balancer SKU. I'm surprised to see this, but there are no other references to those fields in the dashboard code.

This PR sets the field from the preset. If it's empty, there is still defaulting code in KKP that will put basic as value.

Which issue(s) this PR fixes:

Fixes kubermatic/kubermatic#13063

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Set LoadBalancerSKU on Azure clusters if the field is set in the preset

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. labels Feb 9, 2024
@embik
Copy link
Member Author

embik commented Feb 9, 2024

/cc @ahmedwaleedmalik

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2024
@embik embik mentioned this pull request Feb 9, 2024
Closed
@embik
Copy link
Member Author

embik commented Feb 9, 2024

/retest

@embik
Copy link
Member Author

embik commented Feb 9, 2024

/retest

flake?

@embik
Copy link
Member Author

embik commented Feb 9, 2024

/retest

@embik
Copy link
Member Author

embik commented Feb 9, 2024

e2e test is currently broken because commit-based images have been cleaned up, @xrstf is looking into it.

@xrstf
Copy link
Contributor

xrstf commented Feb 9, 2024

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a2d2b0ecdcf0c3144eaa2084f658f7566cb1ab8b

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2024
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit 7ec890f into kubermatic:main Feb 10, 2024
8 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.25 milestone Feb 10, 2024
@dharapvj
Copy link

/cherrypick release/v2.24
/cherrypick release/v2.23

@kubermatic-bot kubermatic-bot mentioned this pull request Feb 12, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@dharapvj: new pull request created: #6508

In response to this:

/cherrypick release/v2.24
/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharapvj
Copy link

/cherrypick release/v2.23

@kubermatic-bot
Copy link
Contributor

@dharapvj: new pull request created: #6509

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Feb 12, 2024
Merged
@embik embik deleted the azure-set-loadbalancer-sku-from-preset branch February 12, 2024 07:42
@xrstf
Copy link
Contributor

xrstf commented Feb 12, 2024

/milestone KKP 2.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.

Azure cluster creation ignore loadBalancerSKU value from preset
6 participants
@embik @xrstf @kubermatic-bot @kubermatic-triage-bot @dharapvj @ahmedwaleedmalik