Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Edge provider #6502

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Add support for Edge provider #6502

merged 3 commits into from
Feb 26, 2024

Conversation

Waseem826
Copy link
Contributor

@Waseem826 Waseem826 commented Feb 6, 2024 •
edited
Loading

What this PR does / why we need it:

  • Add support for Edge provider.

Create Cluster Wizard:

screenshot-localhost_8000-2024 02 23-23_25_15

Initial Nodes Settings:

screenshot-localhost_8000-2024 02 23-23_26_06

  • A new "Copy Script" is also added on the MD details page to copy the joining script for Edge provider Nodes.

screenshot-localhost_8000-2024 02 23-23_24_46

  • Also, machine controller health check is skipped for Edge provider.

Which issue(s) this PR fixes:

Fixes #6499

What type of PR is this?

/kind feature
Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add support for Edge provider.

Documentation:

NONE

@Waseem826 Waseem826 self-assigned this Feb 6, 2024
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/tbd Denotes a PR that needs documentation (change) that will be done later. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Feb 6, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2024
@Waseem826 Waseem826 changed the title Add support for Edge provider WIP ~ Add support for Edge provider Feb 7, 2024
@Waseem826 Waseem826 force-pushed the 6499-add-edge-provider branch from 7e25a0f to de84786 Compare February 7, 2024 10:19
@Waseem826
Copy link
Contributor Author

/test all

@Waseem826 Waseem826 force-pushed the 6499-add-edge-provider branch 3 times, most recently from 273dbc5 to 63688a6 Compare February 19, 2024 18:24
@Waseem826 Waseem826 mentioned this pull request Feb 20, 2024
Closed
@Waseem826 Waseem826 force-pushed the 6499-add-edge-provider branch 2 times, most recently from bc4f3ae to 24aa9f6 Compare February 23, 2024 18:22
@Waseem826 Waseem826 changed the title WIP ~ Add support for Edge provider Add support for Edge provider Feb 23, 2024
@Waseem826 Waseem826 added this to the KKP 2.25 milestone Feb 23, 2024
@Waseem826 Waseem826 marked this pull request as ready for review February 23, 2024 18:30
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2024
@Waseem826 Waseem826 force-pushed the 6499-add-edge-provider branch from 24aa9f6 to fbd64b7 Compare February 26, 2024 08:29
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 154eec84c50eaea30faf02d7614d5e10ef1e0308

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Feb 26, 2024
@Waseem826
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 803bee0 into kubermatic:main Feb 26, 2024
10 checks passed
@Waseem826 Waseem826 deleted the 6499-add-edge-provider branch February 26, 2024 16:48
@csengerszabo csengerszabo mentioned this pull request Mar 5, 2024
Merged
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.

Add Edge provider
3 participants
@Waseem826 @kubermatic-bot @ahmedwaleedmalik