Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable CSI drivers #6395

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Option to disable CSI drivers #6395

merged 4 commits into from
Nov 23, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
This PR adds the required changes in API and UI to support disabling CSI drivers for user clusters.

Which issue(s) this PR fixes:

Fixes #6206

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Support for disabling CSI driver for user clusters

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Nov 23, 2023
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2023
Waseem826
Waseem826 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 55556ffe9cc56d0e65e6cd5ac6d5a288fceb1181

@ahmedwaleedmalik
Copy link
Member Author

/approve

For API 🦀

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@kubermatic-bot kubermatic-bot merged commit 9950bec into kubermatic:main Nov 23, 2023
@kubermatic-bot kubermatic-bot added this to the KKP 2.25 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.

Option to disable CSI drivers
3 participants
@ahmedwaleedmalik @kubermatic-bot @Waseem826