Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.21] Configure OpenStack ingress cluster settings #5865

Merged
merged 1 commit into from
Mar 29, 2023
Merged

[release/v2.21] Configure OpenStack ingress cluster settings #5865

merged 1 commit into from
Mar 29, 2023

Conversation

Waseem826
Copy link
Contributor

What this PR does / why we need it:
This is a manual cherry-pick of #5861.

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Configure Ingress Hostname cluster settings of OpenStack provider.

Documentation:

https://docs.kubermatic.com/kubermatic/v2.21/references/crds/#openstackcloudspec

@Waseem826
Configure OpenStack ingress cluster settings (kubermatic#5861)
9d91413 
* Add functionality to configure `enableIngressHostname` and `ingressHostnameSuffix` for OpenStack provider

* Load security groups, networks and subnets only when cluster credentials are changed

* Mark disk size field as required when form control is marked as required

(cherry picked from commit 12d676d)
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2023
@kubermatic-bot
Copy link
Contributor

@Waseem826: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-dashboard-test-e2e-ce 9d91413 link false /test pre-dashboard-test-e2e-ce

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ab1eabbfbe07e47a2f7a9bfbae0ea322d1dfa7a5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Waseem826,ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit c806534 into kubermatic:release/v2.21 Mar 29, 2023
@Waseem826 Waseem826 deleted the cherrypick-5861-to-release-2.21 branch March 29, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Waseem826 @kubermatic-bot @ahmedwaleedmalik