Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new CNCF GA4 site tag in Hugo config #3627

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 17, 2023

/cc @nate-double-u

Copy link

@chalin: GitHub didn't allow me to request PR reviews from the following users: nate-double-u.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @nate-double-u

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Hi @chalin. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chalin chalin force-pushed the chalin-im-conf-ga4-2023-11-17 branch from 579474d to f95493e Compare November 17, 2023 09:45
@chalin chalin force-pushed the chalin-im-conf-ga4-2023-11-17 branch from f95493e to 7d8e76a Compare November 17, 2023 09:48
@chalin chalin changed the title Use the new CNCF GA4 site tag Use the new CNCF GA4 site tag in Hugo config Nov 17, 2023
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@thesuperzapper
Copy link
Member

@zijianjoy Seeing as the old Google Analytics does not work anymore, we should probably merge this so we are using the CNCF Google Analytics.

We need a root approver.

@zijianjoy
Copy link
Contributor

Sounds good to me for changing the GA4 site tag. Thank you @chalin for the change!

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chalin, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b5e5dcd into kubeflow:master Nov 25, 2023
@chalin chalin deleted the chalin-im-conf-ga4-2023-11-17 branch November 27, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Google Analytics 4 (GA4)
5 participants