-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.5 to version dropdown. #3184
Add 1.5 to version dropdown. #3184
Conversation
/hold Need to cut the 1.5 website branch first. |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
As a side note, I think it would be helpful to think about removing past versions every time there is a new version added. Maybe keep the previous 5 or 6 versions (from v1.0 - v1.5) and remove the rest. Are there users who actually access v0.2 docs? We can discuss this in the retro as well.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: annajung, shannonbradshaw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@shannonbradshaw FYI, I just tried this and got this error, This site can’t be reachedCheck if there is a typo in v1-5-branch.kubeflow.org. |
Still need to cut the branch. Waiting on one more PR. |
Fixes #3133