Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.5 to version dropdown. #3184

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

shannonbradshaw
Copy link
Contributor

Fixes #3133

@shannonbradshaw
Copy link
Contributor Author

shannonbradshaw commented Mar 7, 2022

/hold

Need to cut the 1.5 website branch first.

@shannonbradshaw
Copy link
Contributor Author

/hold cancel

@shannonbradshaw
Copy link
Contributor Author

Copy link
Member

@annajung annajung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

As a side note, I think it would be helpful to think about removing past versions every time there is a new version added. Maybe keep the previous 5 or 6 versions (from v1.0 - v1.5) and remove the rest. Are there users who actually access v0.2 docs? We can discuss this in the retro as well.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, shannonbradshaw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c40bb09 into kubeflow:master Mar 10, 2022
@jbottum
Copy link
Contributor

jbottum commented Mar 11, 2022

@shannonbradshaw FYI, I just tried this and got this error,

This site can’t be reachedCheck if there is a typo in v1-5-branch.kubeflow.org.
DNS_PROBE_FINISHED_NXDOMAIN

@shannonbradshaw
Copy link
Contributor Author

Still need to cut the branch. Waiting on one more PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an entry for the 1.5 release to the docs version dropdown
3 participants