Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebooks: Add docs for notebook idleness and culling #3145

Closed
Tracked by #3130
kimwnasptd opened this issue Feb 10, 2022 · 7 comments
Closed
Tracked by #3130

notebooks: Add docs for notebook idleness and culling #3145

kimwnasptd opened this issue Feb 10, 2022 · 7 comments
Assignees

Comments

@kimwnasptd
Copy link
Member

We've reworked the idleness and culling behavior of the Notebook Controller in KF 1.5 https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md.

We'll need to also update our docs to inform users about:

  1. How to start/stop notebooks
  2. How the controller sets idleness in notebook CRs
  3. Instructions to enable this, as well as migration instructions
  4. Best practices for culling and start/stopping notebooks

cc @kubeflow/wg-notebooks-leads
/assign @kimwnasptd @athamark

@google-oss-prow
Copy link

@kimwnasptd: GitHub didn't allow me to assign the following users: athamark.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

We've reworked the idleness and culling behavior of the Notebook Controller in KF 1.5 https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md.

We'll need to also update our docs to inform users about:

  1. How to start/stop notebooks
  2. How the controller sets idleness in notebook CRs
  3. Instructions to enable this, as well as migration instructions
  4. Best practices for culling and start/stopping notebooks

cc @kubeflow/wg-notebooks-leads
/assign @kimwnasptd @athamark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shannonbradshaw
Copy link
Contributor

@kimwnasptd any updates on this issue?

@varodrig
Copy link
Contributor

@kimwnasptd are you still facing any issues. The issue will be closed soon if there is no news in the next few days, given the issue date. cc @shannonbradshaw

@thesuperzapper
Copy link
Member

I want to highlight that idle culling has been significantly updated in Notebooks 2.0. We now allow for completely custom culling behavior (even for non-Jupyter IDEs, with custom bash scripts now).

Once 2.0 is formerly released, we will update the docs, but you can follow the progress of 2.0 here:

But we could possibly add some docs about the 1.0 feature.

@varodrig
Copy link
Contributor

varodrig commented Feb 2, 2025

@kimwnasptd we are closing this issue due to the inactivity and it seems the issue was resolved. Please let us know if you are still facing the issue.

@varodrig
Copy link
Contributor

varodrig commented Feb 2, 2025

/close

Copy link

@varodrig: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants