Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): update contributing guidelines to use isort #7549

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Apr 12, 2022

Description of your changes:
YAPF is insufficient to fully adhere to the Google Python Style Guide. Specifically, the yapf tool does not make required formatting changes to meet 3.13: Imports formatting.

Note: I do not apply this to kfp/deprecated/ because doing so unfortunately results in circular imports. A tool like this would have helped prevent a circular import error on the basis of import sorting alone by ensuring only one acceptable import order.

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign james-jwu after the PR has been reviewed.
You can assign the PR to them by writing /assign @james-jwu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy connor-mccarthy marked this pull request as ready for review April 12, 2022 20:28
@google-oss-prow google-oss-prow bot requested a review from zijianjoy April 12, 2022 20:28
@connor-mccarthy connor-mccarthy marked this pull request as draft April 12, 2022 22:26
@connor-mccarthy connor-mccarthy force-pushed the add-isort-to-contributing branch from 4b0e340 to 523daa4 Compare April 12, 2022 22:38
@google-oss-prow google-oss-prow bot added size/L and removed size/XL labels Apr 12, 2022
@connor-mccarthy connor-mccarthy marked this pull request as ready for review April 12, 2022 22:50
@connor-mccarthy connor-mccarthy marked this pull request as draft April 12, 2022 23:34
@connor-mccarthy
Copy link
Member Author

/retest

@connor-mccarthy connor-mccarthy marked this pull request as ready for review April 14, 2022 17:53
@connor-mccarthy
Copy link
Member Author

/retest

1 similar comment
@connor-mccarthy
Copy link
Member Author

/retest

@google-oss-prow
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 523daa4 link true /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant