-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): update contributing guidelines to use isort #7549
chore(sdk): update contributing guidelines to use isort #7549
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4b0e340
to
523daa4
Compare
/retest |
/retest |
1 similar comment
/retest |
@connor-mccarthy: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description of your changes:
YAPF is insufficient to fully adhere to the Google Python Style Guide. Specifically, the
yapf
tool does not make required formatting changes to meet 3.13: Imports formatting.Note: I do not apply this to
kfp/deprecated/
because doing so unfortunately results in circular imports. A tool like this would have helped prevent a circular import error on the basis of import sorting alone by ensuring only one acceptable import order.Checklist:
title convention used in this repository.