Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #529: istio: oidc-authservice Cherry pick of #529 on v0.7-branch. #529: istio: oidc-authservice #615

Conversation

yanniszark
Copy link
Contributor

@yanniszark yanniszark commented Nov 14, 2019

This change is Reviewable

@yanniszark
Copy link
Contributor Author

Related to #616

/assign @jlewi @krishnadurai

@jlewi
Copy link
Contributor

jlewi commented Nov 15, 2019

@yanniszark Can you provide me a little bit more context? I tried looking through the linked issues and PRs but couldn't find an overarching explanation of the feature or bug being addressed here.

My high level question is what's the motivation for cherry-picking these changes onto the v0.7-branch? Especially given that next week is Kubecon and we just published our 0.7 blog post is it possible these changes could break 0.7 just as lots of people try it?

Copy link
Contributor

@krishnadurai krishnadurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@krishnadurai
Copy link
Contributor

@jlewi refer to my comment.

@jlewi
Copy link
Contributor

jlewi commented Nov 23, 2019

Thanks @krishnadurai does this PR present any risk to the other configs?

@krishnadurai
Copy link
Contributor

@jlewi These shouldn't affect any other config as OIDC AuthService and Cert-Manger are only used by the existing_arrikto config.

Signed-off-by: Yannis Zarkadas <[email protected]>
Signed-off-by: Yannis Zarkadas <[email protected]>
Signed-off-by: Yannis Zarkadas <[email protected]>
Signed-off-by: Yannis Zarkadas <[email protected]>
@yanniszark yanniszark force-pushed the automated-cherry-pick-of-#529-upstream-v0.7-branch branch from e7a7438 to f73c953 Compare November 28, 2019 15:26
@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 28, 2019
@yanniszark
Copy link
Contributor Author

@jlewi all tests are green after the rebase.
As mentioned, this should only affect the istio_dex config.
I'm leaving a hold in case you want to do another review here.

/approve
/hold

@jlewi
Copy link
Contributor

jlewi commented Dec 3, 2019

/lgtm
/approve
/hold cancel

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, yanniszark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 25bb137 into kubeflow:v0.7-branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants