-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #529: istio: oidc-authservice Cherry pick of #529 on v0.7-branch. #529: istio: oidc-authservice #615
Conversation
Related to #616 /assign @jlewi @krishnadurai |
@yanniszark Can you provide me a little bit more context? I tried looking through the linked issues and PRs but couldn't find an overarching explanation of the feature or bug being addressed here. My high level question is what's the motivation for cherry-picking these changes onto the v0.7-branch? Especially given that next week is Kubecon and we just published our 0.7 blog post is it possible these changes could break 0.7 just as lots of people try it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @krishnadurai does this PR present any risk to the other configs? |
@jlewi These shouldn't affect any other config as OIDC AuthService and Cert-Manger are only used by the existing_arrikto config. |
Signed-off-by: Yannis Zarkadas <[email protected]>
Signed-off-by: Yannis Zarkadas <[email protected]>
Signed-off-by: Yannis Zarkadas <[email protected]>
Signed-off-by: Yannis Zarkadas <[email protected]>
Signed-off-by: Yannis Zarkadas <[email protected]>
Signed-off-by: Yannis Zarkadas <[email protected]>
e7a7438
to
f73c953
Compare
@jlewi all tests are green after the rebase. /approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi, yanniszark The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is