Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all-in-one installation script #43

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Add all-in-one installation script #43

merged 1 commit into from
Apr 1, 2021

Conversation

llhuii
Copy link

@llhuii llhuii commented Apr 1, 2021

fix #21

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 1, 2021
@llhuii llhuii force-pushed the add-installation-all-in-one-script branch 2 times, most recently from b68d182 to 0c0b995 Compare April 1, 2021 04:58
@ugvddm
Copy link

ugvddm commented Apr 1, 2021

:/lgtm

@llhuii llhuii force-pushed the add-installation-all-in-one-script branch from 0c0b995 to 5d74745 Compare April 1, 2021 06:36
@llhuii
Copy link
Author

llhuii commented Apr 1, 2021

/hold

@kubeedge-bot kubeedge-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2021
@llhuii llhuii force-pushed the add-installation-all-in-one-script branch from 5d74745 to 6615258 Compare April 1, 2021 07:00
@llhuii
Copy link
Author

llhuii commented Apr 1, 2021

tested fully
/hold cancel

@kubeedge-bot kubeedge-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2021
@llhuii
Copy link
Author

llhuii commented Apr 1, 2021

/lgtm
/approve

@kubeedge-bot
Copy link
Collaborator

@llhuii: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: llhuii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2021
@llhuii llhuii force-pushed the add-installation-all-in-one-script branch 2 times, most recently from 95792b8 to 29d9f39 Compare April 1, 2021 08:20
@JimmyYang20
Copy link

tested, successfully

@JimmyYang20
Copy link

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2021
@llhuii llhuii force-pushed the add-installation-all-in-one-script branch from 29d9f39 to a8f749c Compare April 1, 2021 08:59
@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2021
@llhuii llhuii force-pushed the add-installation-all-in-one-script branch 2 times, most recently from 8b3543e to 2001bdd Compare April 1, 2021 09:22
@llhuii
Copy link
Author

llhuii commented Apr 1, 2021

Instead of git clone here download every files under build/crds and build/gm/rbac because of large vendor directory.

Add all-in-one installation script
08bb8b4 
1. add all-in-one installation script. also support uninstall operation.
2. update the installation docs using the all-in-one script

Signed-off-by: llhuii <[email protected]>
@llhuii llhuii force-pushed the add-installation-all-in-one-script branch from 2001bdd to 08bb8b4 Compare April 1, 2021 09:27
@JimmyYang20
Copy link

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2021
@JimmyYang20
Copy link

tested it successfully

@kubeedge-bot kubeedge-bot merged commit 88250d2 into kubeedge:main Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimmyYang20 JimmyYang20 Awaiting requested review from JimmyYang20

@TymonXie TymonXie Awaiting requested review from TymonXie

Assignees

@JimmyYang20 JimmyYang20

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support all-in-one installation script on an existing k8s environment
5 participants
@llhuii @ugvddm @kubeedge-bot @JimmyYang20 @authwork