Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM: remove externalIPs when creating k8s service #201

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

llhuii
Copy link

@llhuii llhuii commented Sep 17, 2021

The 'externalIPs' is unnecessary, and in some environment can result in the correspoing
kubelet can't reach api server, and then node unreachable status.

Signed-off-by: llhuii [email protected]

The 'externalIPs' is unncessary, and can result in the correspoing
kubelet can't reach api server, and then node unreachable status.

Signed-off-by: llhuii <[email protected]>
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2021
@JimmyYang20
Copy link

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2021
@llhuii
Copy link
Author

llhuii commented Sep 17, 2021

The way between cloud workers and edge workers can be configurable, not only support NodePort.
Because once edgemesh has been installed and enabled, we can just use ClusterIP instead.

@llhuii
Copy link
Author

llhuii commented Sep 17, 2021

The corresponding issue #202

@llhuii
Copy link
Author

llhuii commented Sep 18, 2021

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: llhuii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2021
@kubeedge-bot kubeedge-bot merged commit 890e66e into kubeedge:main Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants